linux-kernel - Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6825.1479972453@warthog.procyon.org.uk>
Date:   Thu, 24 Nov 2016 07:27:33 +0000
From:   David Howells <dhowells@...hat.com>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     dhowells@...hat.com, linux-fsdevel@...r.kernel.org,
        linux-api@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Andreas Dilger <adilger@...ger.ca> wrote:

> > +		case S_IFCHR:	printf(" character special file\n");	ft = 'c'; break;
> 
> This will overflow 80 columns.  Could use just "character special"?
> 
> > +		case S_IFDIR:	printf(" directory\n");			ft = 'd'; break;
> > +		case S_IFBLK:	printf(" block special file\n");	ft = 'b'; break;
> > +		case S_IFREG:	printf(" regular file\n");		ft = '-'; break;
> > +		case S_IFLNK:	printf(" symbolic link\n");		ft = 'l'; break;
> 
> Having these all as single-word items would make it easier to parse for
> test programs.  Same with "IO Block:" -> "Blocksize:".  Not a huge deal.

Try doing "stat /dev/null".

David