linux-kernel - Re: [PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <626df165-da09-298e-ed60-03d4119caec2@codeaurora.org>
Date:   Thu, 24 Nov 2016 13:34:03 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     Russell King - ARM Linux <linux@...linux.org.uk>,
        Mark Brown <broonie@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Fabio Estevam <fabio.estevam@...escale.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Koji Matsuoka <koji.matsuoka.xm@...esas.com>,
        Thierry Reding <treding@...dia.com>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Simon <horms@...ge.net.au>, linux-renesas-soc@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support

Hi,

On 11/24/2016 10:43 AM, Kuninori Morimoto wrote:
>
> Hi Archit, David, and DRM ML
>
> I had heared that Archit is the maintainer of dw-hdmi driver, but am I wrong ??
> I'm posting this patch series since half year ago, but no response
> from him, and nothing happen (I got review from Russell though).
> Is Archit really maintainer ??
> OTOH, get_maintainer.pl indicates David is the maintainer ?
> What should I do for this patch ??

I'm not the maintainer of the dw-hdmi driver, but I pull in the
changes that go into drm/bridge/

Will pull this.

Thanks,
Archit


>
>> Hi Russell
>>
>>>> @@ -11,4 +11,11 @@ struct dw_hdmi_audio_data {
>>>>  	u8 *eld;
>>>>  };
>>>>
>>>> +struct dw_hdmi_i2s_audio_data {
>>>> +	struct dw_hdmi *hdmi;
>>>> +
>>>> +	void (*write)(struct dw_hdmi *hdmi, u8 val, int offset);
>>>> +	u8 (*read)(struct dw_hdmi *hdmi, int offset);
>>>> +};
>>>
>>> Another slight concern here is why we need this separate data for i2s -
>>> maybe adding the write/read ops to struct dw_hdmi_audio_data would be
>>> a better thing to do, which would then allow the AHB audio to drop
>>> the .base argument in the future.
>>>
>>> I'm not that bothered about this though.  So...
>>
>> Thank you for your feedback.
>> Maybe we can merge these in incremental patch if needed ?
>>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project