linux-kernel - Re: [PATCH] usb: xhci: Remove unuseful 'return' statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50f53faa-f719-0dd1-7cf3-6ed0938a1e5f@cogentembedded.com>
Date:   Thu, 24 Nov 2016 12:30:04 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Baolin Wang <baolin.wang@...aro.org>, mathias.nyman@...el.com,
        gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        broonie@...nel.org
Subject: Re: [PATCH] usb: xhci: Remove unuseful 'return' statement

Hello.

On 11/24/2016 11:13 AM, Baolin Wang wrote:

> Since these 'return' statements are not generally useful in void function,
> remove them.
>
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
[...]
> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
> index 48a26d378..d6f59a3 100644
> --- a/drivers/usb/host/xhci-mem.c
> +++ b/drivers/usb/host/xhci-mem.c
> @@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud
>  	case USB_SPEED_WIRELESS:
>  		xhci_dbg(xhci, "FIXME xHCI doesn't support wireless speeds\n");
>  		return -EINVAL;
> -		break;

    Here you're removing *break* instead but not mentioning this in the patch 
description...

[...]

MBR, Sergei