linux-kernel - Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Nov 2016 12:09:41 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     linux-arm-kernel@...ts.infradead.org
Cc:     Ziji Hu <huziji@...vell.com>,
        Gregory CLEMENT <gregory.clement@...e-electrons.com>,
        Hilbert Zhang <zzhang@...vell.com>,
        Andrew Lunn <andrew@...n.ch>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Romain Perier <romain.perier@...e-electrons.com>,
        Liuliu Zhao <zhaoliul@...vell.com>,
        Peng Zhu <zhupeng@...vell.com>, linux-kernel@...r.kernel.org,
        Nadav Haklai <nadavh@...vell.com>,
        "Jack(SH) Zhu" <jmzhu@...vell.com>, Victor Gu <xigu@...vell.com>,
        Doug Jones <dougj@...vell.com>,
        Jisheng Zhang <jszhang@...vell.com>,
        Yehuda Yitschak <yehuday@...vell.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Xueping Liu <xpliu@...vell.com>,
        Shiwu Zhang <zhangshw@...vell.com>, Yu Cao <yucao@...vell.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        devicetree@...r.kernel.org, Jason Cooper <jason@...edaemon.net>,
        Hanna Hawa <hannah@...vell.com>,
        Kostya Porotchkin <kostap@...vell.com>,
        Rob Herring <robh+dt@...nel.org>, Ryan Gao <ygao@...vell.com>,
        "Wei(SOCP) Liu" <liuw@...vell.com>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Keji Zhang <keji@...vell.com>, linux-mmc@...r.kernel.org,
        Adrian Hunter <adrian.hunter@...el.com>,
        Jimmy Xu <zmxu@...vell.com>, Wilson Ding <dingwei@...vell.com>
Subject: Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

On Thursday, November 24, 2016 6:57:18 PM CET Ziji Hu wrote:
> > 
> > Please explain in the changelog why this is not a generic
> > phy driver (or three of them).
> > 
>         Actually we tried to put the PHY code into Linux PHY framework.
>         But it cannot fit in Linux common PHY framework.
> 
>         Our Xenon SDHC PHY register is a part of Xenon SDHC register set.
>         Besides, during MMC initialization, MMC sequence has to call several PHY functions to complete timing setting.
>         In those PHY setting functions, they have to access SDHC register and know current MMC setting, such as bus width, clock frequency and speed mode.
>         As a result, we have to implement PHY under MMC directory.
> 

Ok, that makes sense, just put the same text in the changelog comment.

	Arnd