linux-kernel - Regression: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871sy1nly9.fsf_-_@purkki.adurom.net>
Date:   Thu, 24 Nov 2016 13:42:22 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Adam Borowski <kilobyte@...band.pl>
Cc:     Philip Muller <philm@...jaro.org>, linux-kernel@...r.kernel.org,
        Nicholas Piggin <npiggin@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thorsten Leemhuis <regressions@...mhuis.info>
Subject: Regression: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

(Adding Thorsten because this is a serious regression and still not fixed)

Adam Borowski <kilobyte@...band.pl> writes:

> Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds
> modversion support for symbols exported from asm files. Architectures
> must include C-style declarations for those symbols in asm/asm-prototypes.h
> in order for them to be versioned.
>
> Add these declarations for x86, and an architecture-independent file that
> can be used for common symbols.
>
> User impact: kernels may fail to load modules at all when
> CONFIG_MODVERSIONS=y.
>
> Signed-off-by: Adam Borowski <kilobyte@...band.pl>
> Tested-by: Kalle Valo <kvalo@...eaurora.org>
> Acked-by: Nicholas Piggin <npiggin@...il.com>
> Tested-by: Peter Wu <peter@...ensteyn.nl>
> Tested-by: Oliver Hartkopp <socketcan@...tkopp.net>

Calling it "may fail" is an understatement, for me _every_ 4.9-rc build
I have tried on my x86 32 bit test laptop has had broken module loading
and hence unable to boot. PLEASE fix this in Linus tree before he
releases 4.9, either applying this patch (which I currently apply
separately everytime I upgrade the kernel) or reverting the offending
commit which started the whole mess. It's not cool to keep the build
broken for this long, people have wasted lots of time because of this.

-- 
Kalle Valo