linux-kernel - Re: [PATCH 2/2] MPI: Fix mpi_powm() when exponent is 0 and the result has no limbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Nov 2016 15:20:58 +0300
From:   Andrey Ryabinin <ryabinin.a.a@...il.com>
To:     David Howells <dhowells@...hat.com>
Cc:     jmorris@...ei.org, Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
        linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
        linux-ima-devel@...ts.sourceforge.net, herbert@...dor.apana.org.au
Subject: Re: [PATCH 2/2] MPI: Fix mpi_powm() when exponent is 0 and the result
 has no limbs

2016-11-24 14:35 GMT+03:00 David Howells <dhowells@...hat.com>:
> Andrey Ryabinin <ryabinin.a.a@...il.com> wrote:
>
>> I'm also made a fix for this yesterday -
>> http://lkml.kernel.org/r/1479918484-31952-1-git-send-email-aryabinin@virtuozzo.com
>
> I should add a record to the MAINTAINERS file that directs patches to MPI to
> keyrings@...r.kernel.org so that I see things like this.
>

Would be nice. It was unclear who maintains it. Since all recent
changes to mpi were merged through crypto tree,
I send this to crypto maintainers.

>> The only small difference is that in my the limb space is not
>> allocated when it's not needed, i.e. when res->nlimbs == 0.
>
> I guess if nlimbs is 0 then the value is 0, right?
>

Right, as far as I understand.


> David