linux-kernel - Re: [PATCH] bpf/samples: Fix PT_REGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161124022427.GA54828@ast-mbp.thefacebook.com>
Date:   Wed, 23 Nov 2016 18:24:28 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Michael Holzheu <holzheu@...ux.vnet.ibm.com>
Cc:     Heiko Carstens <heiko.carstens@...ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Zvonko Kosic <zvonko.kosic@...ibm.com>,
        linux-kernel@...r.kernel.org,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH] bpf/samples: Fix PT_REGS_IP on s390x and use it

On Wed, Nov 23, 2016 at 04:28:39PM +0100, Michael Holzheu wrote:
> The files "sampleip_kern.c" and "trace_event_kern.c" directly access
> "ctx->regs.ip" which is not available on s390x. Fix this and use the
> PT_REGS_IP() macro instead.
> 
> Besides of that also fix the macro for s390x and use psw.addr from pt_regs.
> 
> Reported-by: Zvonko Kosic <zvonko.kosic@...ibm.com>
> Signed-off-by: Michael Holzheu <holzheu@...ux.vnet.ibm.com>

Looks good.
Acked-by: Alexei Starovoitov <ast@...nel.org>

Please resubmit it to net-next and cc Dave.

note that my @plumgrid email no longer vaid.