linux-kernel - Regarding "scsi_lib: Decode T10 vendor IDs" d230823a1c4c3e97afd4c934b86b3975d5e20249

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6-1L6+30LieDibYaspJtwKUwVGfQz4bp5de=YdxuD=Bkw8eg@mail.gmail.com>
Date:   Thu, 24 Nov 2016 16:48:41 +0100
From:   Sylvain Munaut <s.munaut@...tever-company.com>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Paul Mackerras <paulus@...abs.org>,
        Hannes Reinecke <hare@...e.com>,
        Bart Van Assche <bart.vanassche@...disk.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Regarding "scsi_lib: Decode T10 vendor IDs" d230823a1c4c3e97afd4c934b86b3975d5e20249

Hi,

Regarding this commit :

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d230823a1c4c3e97afd4c934b86b3975d5e20249

Looking at both the code and the comment, it seems to me you wanted
'T10' id to be a last resort if nothing else was available.

If that was the intent, it's not working ...

I have a Samsung 850 Pro SSD that has the NAA identifier after the T10
one in the vpd_pg83 and so it's returning the T10 now because it's
longer.

Did I misunderstand the intent ? Or is it a bug ? (for the latter, I
can write a patch myself, I just didn't want to loose my time if I
misunderstood).

Cheers,

   Sylvain Munaut