linux-kernel - Re: [PATCH] pinctrl: imx: fix imx_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fac988ce-f5be-e50c-8436-c122175f03da@mentor.com>
Date:   Thu, 24 Nov 2016 22:17:55 +0200
From:   Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
To:     Gary Bisson <gary.bisson@...ndarydevices.com>,
        <shawnguo@...nel.org>
CC:     <linus.walleij@...aro.org>, <van.freenix@...il.com>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

Hi Gary,

On 11/24/2016 08:11 PM, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <gary.bisson@...ndarydevices.com>
> ---
>  drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
>  	imx_pinctrl_desc->name = dev_name(&pdev->dev);
>  	imx_pinctrl_desc->pins = info->pins;
>  	imx_pinctrl_desc->npins = info->npins;
> -	imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> -	imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> -	imx_pinctrl_desc->confops = &imx_pinconf_ops,
> -	imx_pinctrl_desc->owner = THIS_MODULE,
> +	imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> +	imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> +	imx_pinctrl_desc->confops = &imx_pinconf_ops;
> +	imx_pinctrl_desc->owner = THIS_MODULE;
>
>  	ret = imx_pinctrl_probe_dt(pdev, info);
>  	if (ret) {
>

excellent catch, my compiler does not report the issue.

Subject and commit message are not quite informative, but
the change is trivial, so please feel free to add my

Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>

--
With best wishes,
Vladimir