linux-kernel - Re: [PATCH 0/7] overlayfs: fix ro/rw fd data inconsistecies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxiQMrR83Y5vPEUcXDYvarcpb7AdkDAXZiwF7Rhjt7hWsA@mail.gmail.com>
Date:   Thu, 24 Nov 2016 22:50:48 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Miklos Szeredi <miklos@...redi.hu>
Cc:     "linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Miklos Szeredi <mszeredi@...hat.com>
Subject: Re: [PATCH 0/7] overlayfs: fix ro/rw fd data inconsistecies

On Thu, Nov 24, 2016 at 4:14 PM, Miklos Szeredi <miklos@...redi.hu> wrote:
> On Thu, Nov 24, 2016 at 11:55 AM, Miklos Szeredi <mszeredi@...hat.com> wrote:
>> A file is opened for read-only, opened read-write (resulting in a copy up)
>> and modified.  The data read back from the the read-only fd will be stale
>> in this case (the read-only file descriptor still refers to the lower,
>> unmodified file).
>>
>> This patchset fixes issues related to this corner case.
>>
>> The VFS impact is minimal and performance in the non-corner cases shouldn't
>> suffer.
>
> Git tree is here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git #overlayfs-rorw
>

passed my tests.
I now run all my tests (including unionmount-testsuite) on a setup of
overlayfs over xfs with reflink:
- xfstests - from my github overlayfs-devel branch
  -g quick and overlay/*
  including new test 016 to check ro/rw fd data inconsistencies
- pjdfstest - from my github overlayfs-devel branch
  including acl/xattr tests
- unionmount-testsuite - from my github overlayfs-devel branch
  without recycling (--ov), with mount recycle -(-ov=0) and with mount
recycle and
  layers (--ov=10)

Tested-by: Amir Goldstein <amir73il@...il.com>