linux-kernel - Re: [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161124210105.ykmbednlmae52tla@intel.com>
Date:   Thu, 24 Nov 2016 23:01:05 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:     Nayna Jain <nayna@...ux.vnet.ibm.com>,
        tpmdd-devel@...ts.sourceforge.net, peterhuewe@....de,
        tpmdd@...horst.net, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/3] tpm: move event log init functions to
 tpm_eventlog_init.c

On Wed, Nov 23, 2016 at 12:38:30PM -0700, Jason Gunthorpe wrote:
> On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote:
> > The device driver code for the event log has the init functions and
> > TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c).
> > 
> > Since the initialization functions are common with the TPM 2.0 event
> > log support, this patch splits tpm_eventlog.c to have only TPM 1.2
> > event log parsing logic and moves the init functions into
> > tpm_eventlog_init.c.
> 
> I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this
> _init thing..
> 
> Jason

I would rather see tpm1-eventlog.c and tpm2-eventlog.c as we already
have tpm2-cmd.c for the sake of consistency.

/Jarkko