linux-kernel - Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jJ4kxcT0MVi3mz0zKRrEiRaNfQqPvY6y5bTHpkPpiU3A@mail.gmail.com>
Date:   Thu, 24 Nov 2016 22:06:59 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Rafael Wysocki <rafael.j.wysocki@...el.com>,
        Marcin Koss <marcin.koss@...el.com>,
        Lukasz Odzioba <lukasz.odzioba@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

On Wed, Nov 23, 2016 at 8:01 PM, Jacob Pan
<jacob.jun.pan@...ux.intel.com> wrote:
> Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added
> contraint_to_pl() function to return index into an array. But it
> can potentially return -EINVAL if powercap layer sends an out of
> range constraint ID. This patch adds sanity check.
>
> Unnecessary RAPL domain pointer check is removed since it must be
> initialized before calling rapl_unit_xlate().
>
> Reported-by: Odzioba, Lukasz <lukasz.odzioba@...el.com>
> Reported-by: Koss, Marcin <marcin.koss@...el.com>

Does this depend on the Thomas' series only?

Also, it looks like a Fixes: tag should be present here.

>
> Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>

Thanks,
Rafael