[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161125080838.mpzflnz7epo6wv6g@intel.com>
Date: Fri, 25 Nov 2016 10:08:38 +0200
From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc: Nayna Jain <nayna@...ux.vnet.ibm.com>,
tpmdd-devel@...ts.sourceforge.net, peterhuewe@....de,
tpmdd@...horst.net, linux-kernel@...r.kernel.org,
linux-security-module@...r.kernel.org
Subject: Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with
a static array
On Thu, Nov 24, 2016 at 09:53:13AM -0700, Jason Gunthorpe wrote:
> On Thu, Nov 24, 2016 at 03:57:23PM +0200, Jarkko Sakkinen wrote:
> > I manually added the changes to:
> >
> > tpm: replace dynamically allocated bios_dir with a static array
>
> For this patch..
>
> Could drop 'int rc' from tpm1_chip_register, but it will come back in
> a later patch
>
> Could dump TPM_NUM_EVENT_LOG_FILES and just use
> ARRAY_SIZE(chip->bios_dir)
Not a bug fix. Happy take a patch after the pull request.
> Now the the stub for tpm_bios_log_setup can properly return -ENODEV
>
> This is no good at this point in the series - we need the ENODEV
> detection in tpm_chip_register() from the 'Fix handle of missing event
> log' moved into this patch, because it now returns ENODEV due to
> sercurityfs
Sure it would be cleaner but not really necessary. Do you really think
this is mandatory? No matter how I reorder patches this will require
time and effort to fix various merge conflicts because of the replacemnt
of event log. After that I have to test everything.
Not doing this for light reasons...
> The commit 'tpm: vtpm_proxy: Do not access host's event log' still
> needs a proper commit message - it doesn't match what the patch is
> doing at all.
The commit message otherwise great except for the short summary, which
is now fixed.
> If you are going to be editing the patches I'd suggest squashing all
> the bug fix ones with proper credit so it at least makes sense to
> read..
>
> Jason
I do not have interest to edit patches more than I have to.
/Jarkko
Powered by blists - more mailing lists