linux-kernel - Re: [PATCH] clocksource/drivers/moxart: fix memory leak on timer on error exit paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e457701-0f93-661c-a4b1-3055ad8d8bef@linaro.org>
Date:   Fri, 25 Nov 2016 10:24:46 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Colin King <colin.king@...onical.com>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/moxart: fix memory leak on timer on
 error exit paths

On 24/11/2016 16:16, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The timer is not being free'd on the error exit paths, causing a small
> memory leak.  Add an err exit path that free's timer and returns the
> error status in ret.

Hi Colin,

thanks for sending a fix for this. However, if you are in the process of
fixing the error handling in this init function, you should take the
opportunity to fix not only the mem leak but also rollback clk_get and
request_irq.

  -- Daniel

[ ... ]

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog