linux-kernel - Re: [PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161125125914.GY2119@mail.corp.redhat.com>
Date:   Fri, 25 Nov 2016 13:59:14 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        linux-input@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3

On Nov 25 2016 or thereabouts, Bastien Nocera wrote:
> On Fri, 2016-11-25 at 11:03 +0100, Benjamin Tissoires wrote:
> > One more device requiring a quirk :/
> > 
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> 
> Tested-by: Bastien Nocera <hadess@...ess.net>
> 
> > ---
> >  drivers/hid/hid-sensor-hub.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-
> > hub.c
> > index 50aad26..f9440b6 100644
> > --- a/drivers/hid/hid-sensor-hub.c
> > +++ b/drivers/hid/hid-sensor-hub.c
> > @@ -798,6 +798,9 @@ static const struct hid_device_id
> > sensor_hub_devices[] = {
> >  	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> > USB_VENDOR_ID_MICROSOFT,
> >  			USB_DEVICE_ID_MS_TYPE_COVER_2),
> >  			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> > +	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> > USB_VENDOR_ID_MICROSOFT,
> > +			0x07bd), /* Microsoft Surface 3 TypeCover */
> 
> The sensor is not in the TypeCover though, it's in the main device.

Oops, yes, sorry. I have been traumatised by the type cover apparently
:)

Benjamin

> 
> > +			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> >  	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> > USB_VENDOR_ID_STM_0,
> >  			USB_DEVICE_ID_STM_HID_SENSOR),
> >  			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},