linux-kernel - Re: [PATCH] staging: most: Eliminate symbolic permissions usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201611252047.kKLnsWjQ%fengguang.wu@intel.com>
Date:   Fri, 25 Nov 2016 21:01:33 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jason Litzinger <jlitzingerdev@...il.com>
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org,
        christian.gromm@...rochip.com, andrey.shvetsov@....de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: most: Eliminate symbolic permissions usage

Hi Jason,

[auto build test ERROR on staging/staging-testing]
[cannot apply to v4.9-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jason-Litzinger/staging-most-Eliminate-symbolic-permissions-usage/20161125-194750
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

>> drivers/staging/most/mostcore/core.c:1062:1: error: expected ',' or ';' before 'static'
    static struct attribute *most_aim_def_attrs[] = {
    ^~~~~~
>> drivers/staging/most/mostcore/core.c:1071:19: error: 'most_aim_def_attrs' undeclared here (not in a function)
     .default_attrs = most_aim_def_attrs,
                      ^~~~~~~~~~~~~~~~~~
   drivers/staging/most/mostcore/core.c:1059:34: warning: 'most_aim_attr_remove_link' defined but not used [-Wunused-variable]
    static struct most_aim_attribute most_aim_attr_remove_link =
                                     ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/most/mostcore/core.c:1016:34: warning: 'most_aim_attr_add_link' defined but not used [-Wunused-variable]
    static struct most_aim_attribute most_aim_attr_add_link =
                                     ^~~~~~~~~~~~~~~~~~~~~~

vim +1062 drivers/staging/most/mostcore/core.c

57562a72 Christian Gromm 2015-07-24  1056  	return len;
57562a72 Christian Gromm 2015-07-24  1057  }
57562a72 Christian Gromm 2015-07-24  1058  
c942ea7a Adrian Remonda  2015-08-14  1059  static struct most_aim_attribute most_aim_attr_remove_link =
c383d574 Jason Litzinger 2016-11-24  1060  	__ATTR_WO(remove_link)
57562a72 Christian Gromm 2015-07-24  1061  
57562a72 Christian Gromm 2015-07-24 @1062  static struct attribute *most_aim_def_attrs[] = {
57562a72 Christian Gromm 2015-07-24  1063  	&most_aim_attr_add_link.attr,
57562a72 Christian Gromm 2015-07-24  1064  	&most_aim_attr_remove_link.attr,
57562a72 Christian Gromm 2015-07-24  1065  	NULL,
57562a72 Christian Gromm 2015-07-24  1066  };
57562a72 Christian Gromm 2015-07-24  1067  
57562a72 Christian Gromm 2015-07-24  1068  static struct kobj_type most_aim_ktype = {
57562a72 Christian Gromm 2015-07-24  1069  	.sysfs_ops = &most_aim_sysfs_ops,
57562a72 Christian Gromm 2015-07-24  1070  	.release = most_aim_release,
57562a72 Christian Gromm 2015-07-24 @1071  	.default_attrs = most_aim_def_attrs,
57562a72 Christian Gromm 2015-07-24  1072  };
57562a72 Christian Gromm 2015-07-24  1073  
57562a72 Christian Gromm 2015-07-24  1074  static struct kset *most_aim_kset;

:::::: The code at line 1062 was first introduced by commit
:::::: 57562a72414ca35b2e614cfe0a1b1a7b7e7813dd Staging: most: add MOST driver's core module

:::::: TO: Christian Gromm <christian.gromm@...rochip.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (45142 bytes)