linux-kernel - Re: [RESEND PATCH v5 2/5] mtd: ubi: use 'max_bad_blocks' to compute bad_peb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e6be8fb-1787-ff25-7e35-a264de86db6d@nod.at>
Date:   Fri, 25 Nov 2016 15:03:45 +0100
From:   Richard Weinberger <richard@....at>
To:     Brian Norris <computersforpeace@...il.com>,
        Zach Brown <zach.brown@...com>
Cc:     dwmw2@...radead.org, boris.brezillon@...e-electrons.com,
        dedekind1@...il.com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v5 2/5] mtd: ubi: use 'max_bad_blocks' to compute
 bad_peb_limit if available

On 25.11.2016 14:37, Richard Weinberger wrote:
>> Are you sure you want to even override the user-provided
>> max_beb_per1024 value taken from the mtd= line? I'd think if someone
>> went as far as to specify this in the kernel command line, they don't
>> expect it to get overridden. Just my two cents.
> 
> I agree. With this patch applied the limit can be set via Kconfig, cmdline and automatically.
> IMHO the automatic value via mtd_max_bad_blocks and over-writeable via cmdline and Kconfig.

s/and/should be/

Thanks,
//richard