linux-kernel - Re: [PATCH] Media: Platform: Omap3isp: Do not forget to call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2236670.bOO96ZUSu8@avalon>
Date:   Fri, 25 Nov 2016 16:27:49 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Shailendra Verma <shailendra.v@...sung.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shailendra Verma <shailendra.capricorn@...il.com>,
        vidushi.koul@...sung.com
Subject: Re: [PATCH] Media: Platform: Omap3isp: Do not forget to call

Hi Shailendra,

Thank you for the patch.

On Friday 25 Nov 2016 10:14:32 Shailendra Verma wrote:
> v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition
> before returing from the function.
> 
> Signed-off-by: Shailendra Verma <shailendra.v@...sung.com>
> ---
>  drivers/media/platform/omap3isp/ispvideo.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/omap3isp/ispvideo.c
> b/drivers/media/platform/omap3isp/ispvideo.c index 7354469..2822e2f 100644
> --- a/drivers/media/platform/omap3isp/ispvideo.c
> +++ b/drivers/media/platform/omap3isp/ispvideo.c
> @@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file)
>  done:
>  	if (ret < 0) {
>  		v4l2_fh_del(&handle->vfh);
> +		v4l2_fh_exit(&handle->vfh);

While at it you should call v4l2_fh_exit() in the isp_video_release() function 
as well. I propose updating the commit message to

    v4l: omap3isp: Clean up file handle in open() and release()
    
    Both functions initialize the file handle with v4l2_fh_init() and thus
    need to call clean up with v4l2_fh_exit() as appropriate. Fix it.

Same comment for the OMAP4 ISS patches you've submitted.

>  		kfree(handle);
>  	}

-- 
Regards,

Laurent Pinchart