linux-kernel - Re: [f2fs-dev] [PATCH 2/2] f2fs: allow dio read for LFS mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22d105b6-3393-eee0-f377-af1ab00141f2@kernel.org>
Date:   Fri, 25 Nov 2016 23:54:43 +0800
From:   Chao Yu <chao@...nel.org>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: allow dio read for LFS mode

On 2016/11/12 5:03, Jaegeuk Kim wrote:
> We can allow dio reads for LFS mode, while doing buffered writes for dio writes.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>  fs/f2fs/data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index ca53da5..996b9ae 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1732,7 +1732,7 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
>  
>  	if (f2fs_encrypted_inode(inode) && S_ISREG(inode->i_mode))
>  		return 0;
> -	if (test_opt(F2FS_I_SB(inode), LFS))
> +	if (rw == WRITE && test_opt(F2FS_I_SB(inode), LFS))

For LFS mode, we must disallow any IPU in main area including direct write,
instead of both direct read and write, so this patch relieves the restriction?

IIUC, please add:

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,

>  		return 0;
>  
>  	trace_f2fs_direct_IO_enter(inode, offset, count, rw);
>