linux-kernel - Re: [PATCH v3 1/2] Input - soc_button_array: use gpio_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2016 11:38:37 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] Input - soc_button_array: use gpio_is_valid()

On Fri, Nov 25, 2016 at 05:36:41PM +0100, Benjamin Tissoires wrote:
> gpio_keys will later use gpio_is_valid(). To match the actual
> behavior, we should use it here too.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Applied, thank you.

> 
> ---
> 
> no changes in v3
> 
> Changes in v2:
> - fixed gpio_is_valid(gpio) -> !gpio_is_valid(gpio)
> ---
>  drivers/input/misc/soc_button_array.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index c14b827..bbd433c 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -17,6 +17,7 @@
>  #include <linux/acpi.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/gpio_keys.h>
> +#include <linux/gpio.h>
>  #include <linux/platform_device.h>
>  
>  /*
> @@ -92,7 +93,7 @@ soc_button_device_create(struct platform_device *pdev,
>  			continue;
>  
>  		gpio = soc_button_lookup_gpio(&pdev->dev, info->acpi_index);
> -		if (gpio < 0)
> +		if (!gpio_is_valid(gpio))
>  			continue;
>  
>  		gpio_keys[n_buttons].type = info->event_type;
> -- 
> 2.7.4
> 

-- 
Dmitry