linux-kernel - Re: [PATCH v2] staging: lustre: osc: Performance tune for LRU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161125221241.GN6266@mwanda>
Date:   Sat, 26 Nov 2016 01:12:41 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     James Simmons <jsimmons@...radead.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        Oleg Drokin <oleg.drokin@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jinshan Xiong <jinshan.xiong@...el.com>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH v2] staging: lustre: osc: Performance tune for LRU

On Wed, Nov 23, 2016 at 06:01:45PM -0500, James Simmons wrote:
> From: Jinshan Xiong <jinshan.xiong@...el.com>
> 
> Early launch page LRU work in osc_io_rw_iter_init();
> Change the page LRU shrinking policy by OSC attributes;
> Delete the contented lock osc_object::oo_seatbelt
> 

The cli_name() stuff should be in a separate patch.  It's hard to review
this stuff (or possibly I just found the first deal breaker and gave
up).

Anyway, please review this again and break it up into separate patches.

regards,
dan carpenter

PS:  I glanced at the patch again and the very first line is changing
"lru" to "LRU" in a comment.  We'll get a million performance increases
from that I bet.  Don't mix random white space changes into it...