linux-kernel - Re: [PATCH] orangefs: Axe some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 26 Nov 2016 08:51:57 -0500
From:   Mike Marshall <hubcap@...ibond.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Martin Brandenburg <martin@...ibond.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] orangefs: Axe some dead code

I think I understand what you're saying, except for this part:

> would have been secretly disapointed at your lack of
> courage in my heart but it would have been normal and fine.

I'm pretty sure that Linus won't accept a pull request from me
at the wrong time and that I won't send one at the wrong time
on purpose.

I've been laboring under the belief that the rc period is when
we "push only patches that do not include new functionalities",
and I would have thought that stripping out a few lines of dead
code would be appropriate then.

-Mike

On Sat, Nov 26, 2016 at 5:02 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Fri, Nov 25, 2016 at 06:09:39PM -0500, Mike Marshall wrote:
>> We're on rc7 now. Linus said in LWN that there might be a rc8 this time.
>> I'll try to get this pulled in 4.9-rc8 I hope, or sometime in 4.10...
>> it is just a
>> few lines of code that I don't think can be reached. Sorry for the confusion.
>
> It's not -rc material at all.  Especially not after -rc2.  If you had
> said 4.11, I would have been secretly disapointed at your lack of
> courage in my heart but it would have been normal and fine.  Merging
> this in 4.10 is the earliest reasonable.
>
> regards,
> dan carpenter
>