linux-kernel - Re: [PATCH] Fixed a functions to rbd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 26 Nov 2016 16:37:33 +0200
From:   Ozgur Karatas <mueddib@...sey.org>
To:     idryomov <idryomov@...il.com>, sage <sage@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fixed a functions to rbd.c

Hello all,

I fixed to checkpatch.pl error and fixed two errors.

static char* obj_op_name(enum obj_operation_type op_type)
static bool single_major = false;

Signed-off-by: Ozgur Karatas <mueddib@...sey.org>
---
 drivers/block/rbd.c
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c

@@ -2,7 +2,6 @@
 /*
    rbd.c -- Export ceph rados objects as a Linux block device

-
    based on drivers/block/osdblk.c:

    Copyright 2009 Red Hat, Inc.
@@ -24,7 +23,7 @@

    For usage instructions, please refer to:

- Documentation/ABI/testing/sysfs-bus-rbd
+ Documentation/ABI/testing/sysfs-bus-rbd

  */

@@ -449,7 +448,7 @@ static struct workqueue_struct *rbd_wq;
  * Default to false for now, as single-major requires >= 0.75 version of
  * userspace rbd utility.
  */
-static bool single_major = false;
+static bool single_major;
 module_param(single_major, bool, S_IRUGO);
 MODULE_PARM_DESC(single_major, "Use a single major number for all rbd devices (default: false)");

@@ -866,7 +865,7 @@ static int parse_rbd_opts_token(char *c, void *private)
         return 0;
 }

-static char* obj_op_name(enum obj_operation_type op_type)
+static char *obj_op_name(enum obj_operation_type op_type)
 {
         switch (op_type) {
         case OBJ_OP_READ:
@@ -5587,15 +5586,14 @@ static int rbd_dev_header_info(struct rbd_device *rbd_dev)
  */
 static inline size_t next_token(const char **buf)
 {
- /*
- * These are the characters that produce nonzero for
- * isspace() in the "C" and "POSIX" locales.
- */
- const char *spaces = " \f\n\r\t\v";
-
- *buf += strspn(*buf, spaces); /* Find start of token */
+/*
+ * These are the characters that produce nonzero for
+ * isspace() in the "C" and "POSIX" locales.
+*/

- return strcspn(*buf, spaces); /* Return token length */
+const char *spaces = " \f\n\r\t\v";
+*buf += strspn(*buf, spaces); /* Find start of token */
+return strcspn(*buf, spaces); /* Return token length */