linux-kernel - Re: [PATCH 4/5] regulator: Add support for TI TWL6032

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1480191847.18423.1.camel@mentor.com>
Date:   Sat, 26 Nov 2016 20:24:10 +0000
From:   "Rosia, Nicolae" <Nicolae_Rosia@...tor.com>
To:     "lkp@...el.com" <lkp@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "baruch@...s.co.il" <baruch@...s.co.il>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
        "tony@...mide.com" <tony@...mide.com>
Subject: Re: [PATCH 4/5] regulator: Add support for TI TWL6032

Hi,

On Sun, 2016-11-27 at 02:55 +0800, kbuild test robot wrote:
> Hi Nicolae,
> 
> [auto build test ERROR on omap/for-next]
> [also build test ERROR on v4.9-rc6]
> [cannot apply to next-20161125]
> [if your patch is applied to the wrong git tree, please drop us a
> note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Nicolae-Rosia/mfd-tw
> l-improvements-and-new-regulator-driver/20161127-022201
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-
> omap.git for-next
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from drivers/regulator/twl6032-regulator.c:11:0:
> > > drivers/regulator/twl6032-regulator.c:557:31: error:
> > > 'twl6032_regulator_driver_ids' undeclared here (not in a
> > > function)
> 
>     MODULE_DEVICE_TABLE(platform, twl6032_regulator_driver_ids);
>                                   ^
>    include/linux/module.h:213:21: note: in definition of macro
> 'MODULE_DEVICE_TABLE'
>     extern const typeof(name)
> __mod_##type##__##name##_device_table  \
>                         ^~~~
> > > include/linux/module.h:213:27: error:
> > > '__mod_platform__twl6032_regulator_driver_ids_device_table'
> > > aliased to undefined symbol 'twl6032_regulator_driver_ids'
> 
>     extern const typeof(name)
> __mod_##type##__##name##_device_table  \
>                               ^
> > > drivers/regulator/twl6032-regulator.c:557:1: note: in expansion
> > > of macro 'MODULE_DEVICE_TABLE'
> 
>     MODULE_DEVICE_TABLE(platform, twl6032_regulator_driver_ids);
>     ^~~~~~~~~~~~~~~~~~~
> 
> vim +/twl6032_regulator_driver_ids +557 drivers/regulator/twl6032-
> regulator.c
> 
>    551	
>    552	static const struct of_device_id twl6032_dt_match[] = {
>    553		{ .compatible = "ti,twl6032-regulator" },
>    554		{ /* last entry */ }
>    555	};
>    556	
>  > 557	MODULE_DEVICE_TABLE(platform,
> twl6032_regulator_driver_ids);
>    558	
>    559	static struct platform_driver twl6032_regulator_driver
> = {
>    560		.driver = {

Thanks, I did not notice this since I was only testing using built-in
module.
I will wait for comments before sending V2, untill then here's an
inline patch with the fix.


Best regards,
Nicolae