linux-kernel - Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1611261420400.3602@nanos>
Date:   Sat, 26 Nov 2016 14:20:59 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Pavel Machek <pavel@....cz>
cc:     Grzegorz Andrejczuk <grzegorz.andrejczuk@...el.com>,
        mingo@...hat.com, hpa@...or.com, x86@...nel.org, bp@...e.de,
        dave.hansen@...ux.intel.com, lukasz.daniluk@...el.com,
        james.h.cownie@...el.com, jacob.jun.pan@...el.com,
        Piotr.Luc@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot

On Sat, 26 Nov 2016, Pavel Machek wrote:

> On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > +#ifdef CONFIG_X86_64
> > > +static int phi_r3mwait_disabled __read_mostly;
> > > +
> > > +static int __init phir3mwait_disable(char *__unused)
> > > +{
> > > +	phi_r3mwait_disabled = 1;
> > > +	pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> > 
> > Why would that be a warning? The sysadmin added the command line switch, so
> > why does he needs to be warned?
> 
> Its telling admin he did not make a typo on the command line. We often do that....

Definitely not at the warning level.