[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 26 Nov 2016 18:53:41 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [git pull] vfs fix
On Sat, Nov 26, 2016 at 6:25 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> Two issues here. One is that iov_iter_get_pages{,_alloc}() calling
> conventions are fucking ugly.
No arguments there. I was going to suggest adding an "int *npages"
argument and letting that function fill that in together with the page
array, but it's not like that is going to really make the interface
any prettier.
> Anyway, leaving that BUG_ON() had been wrong; I can send a followup
> massaging that thing as you've suggested, if you are interested in
> that. But keep in mind that the whole iov_iter_get_pages...() calling
> conventions are going to be changed, hopefully soon.
If it indeed happens soon, I can certainly live with the existing code
as a temporary "ugly but it works". But if it ends up being post-4.10
I'd prefer to clean this up independently first, ok?
Linus
Powered by blists - more mailing lists