linux-kernel - Re: [PATCH 1/2] bcache: Remove redundant set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Nov 2016 15:57:38 +0800
From:   Coly Li <i@...y.li>
To:     Yijing Wang <wangyijing@...wei.com>, axboe@...com,
        kent.overstreet@...il.com
Cc:     git@...ux.ewheeler.net, colyli@...e.de,
        linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] bcache: Remove redundant set_capacity

On 2016/11/25 上午9:39, Yijing Wang wrote:
> set_capacity() has been called in bcache_device_init(),
> remove the redundant one.
> 
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> ---
>  drivers/md/bcache/super.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 849ad44..b638a16 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1126,9 +1126,6 @@ static int cached_dev_init(struct cached_dev *dc, unsigned block_size)
>  	if (ret)
>  		return ret;
>  
> -	set_capacity(dc->disk.disk,
> -		     dc->bdev->bd_part->nr_sects - dc->sb.data_offset);
> -
>  	dc->disk.disk->queue->backing_dev_info.ra_pages =
>  		max(dc->disk.disk->queue->backing_dev_info.ra_pages,
>  		    q->backing_dev_info.ra_pages);
> 

Hi Yijing,

Nice catch, it looks good to me.

Acked-by: Coly Li <colyli@...e.de>

-- 
Coly Li