linux-kernel - Re: [PATCH] net: fec: turn on device when extracting statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ddb5842-0ece-2950-214f-f56db808ffbd@cogentembedded.com>
Date:   Mon, 28 Nov 2016 10:06:31 +0300
From:   Nikita Yushchenko <nikita.yoush@...entembedded.com>
To:     David Miller <davem@...emloft.net>
Cc:     fugang.duan@....com, troy.kisky@...ndarydevices.com,
        andrew@...n.ch, eric@...int.com, tremyfr@...il.com,
        johannes@...solutions.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, cphealy@...il.com,
        Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH] net: fec: turn on device when extracting statistics



28.11.2016 04:29, David Miller пишет:
> From: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> Date: Fri, 25 Nov 2016 13:02:00 +0300
> 
>> +	int i, ret;
>> +
>> +	ret = pm_runtime_get_sync(&fep->pdev->dev);
>> +	if (IS_ERR_VALUE(ret)) {
>> +		memset(data, 0, sizeof(*data) * ARRAY_SIZE(fec_stats));
>> +		return;
>> +	}
> 
> This really isn't the way to do this.
> 
> When the device is suspended and the clocks are going to be stopped,
> you must fetch the statistic values into a software copy and provide
> those if the device is suspended when statistics are requested.

Ok, can do that, although can't see what's wrong with waking device
here. The situation of requesting stats on down device isn't something
widely used, thus keeping handling of that as local as possible looks
better for me.