linux-kernel - [tip:x86/urgent] x86/build: Annotate die() with noreturn to fix build warning on clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-adee8705d2517f0e163ffc45e8d7f9e97a58f1f6@git.kernel.org>
Date:   Sun, 27 Nov 2016 23:20:25 -0800
From:   tip-bot for Peter Foley <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, torvalds@...ux-foundation.org, mingo@...nel.org,
        peterz@...radead.org, tglx@...utronix.de, pefoley2@...oley.com,
        linux-kernel@...r.kernel.org
Subject: [tip:x86/urgent] x86/build: Annotate die() with noreturn to fix
 build warning on clang

Commit-ID:  adee8705d2517f0e163ffc45e8d7f9e97a58f1f6
Gitweb:     http://git.kernel.org/tip/adee8705d2517f0e163ffc45e8d7f9e97a58f1f6
Author:     Peter Foley <pefoley2@...oley.com>
AuthorDate: Sat, 26 Nov 2016 17:22:29 -0500
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Mon, 28 Nov 2016 07:47:22 +0100

x86/build: Annotate die() with noreturn to fix build warning on clang

Fixes below warning with clang:

  In file included from ../arch/x86/tools/relocs_64.c:17:
  ../arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Signed-off-by: Peter Foley <pefoley2@...oley.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Link: http://lkml.kernel.org/r/20161126222229.673-1-pefoley2@pefoley.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/tools/relocs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/tools/relocs.h b/arch/x86/tools/relocs.h
index f595906..1d23bf9 100644
--- a/arch/x86/tools/relocs.h
+++ b/arch/x86/tools/relocs.h
@@ -16,7 +16,7 @@
 #include <regex.h>
 #include <tools/le_byteshift.h>
 
-void die(char *fmt, ...);
+void die(char *fmt, ...) __attribute__((noreturn));
 
 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))