lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 24 Nov 2016 13:51:57 +0100
From:   Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     Gabriel Krisman Bertazi <krisman@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] GenWQE: drop duplicate headers

Hi Geliang,


> On 23 Nov 2016, at 15:24, Geliang Tang <geliangtang@...il.com> wrote:
> 
> Drop duplicate headers module.h and delay.h.
> 
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
> drivers/misc/genwqe/card_base.c  | 1 -
> drivers/misc/genwqe/card_ddcb.c  | 1 -
> drivers/misc/genwqe/card_utils.c | 1 -
> 3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
> index 6c1f49a..b6f2edf 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -34,7 +34,6 @@
> #include <linux/wait.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> -#include <linux/module.h>
> #include <linux/notifier.h>
> #include <linux/device.h>
> #include <linux/log2.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
> index ddfeefe..332a0d1 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -34,7 +34,6 @@
> #include <linux/string.h>
> #include <linux/dma-mapping.h>
> #include <linux/delay.h>
> -#include <linux/module.h>
> #include <linux/interrupt.h>
> #include <linux/crc-itu-t.h>
> 
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 147b830..a1859e5 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -36,7 +36,6 @@
> #include <linux/ctype.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/delay.h>
> #include <asm/pgtable.h>
> 
> #include "genwqe_driver.h"
> -- 
> 2.9.3
> 

thanks for the simplification. Did you find those by manual inspection, or did you use a tool?

Acked-by: Frank Haverkamp <haver@...ux.vnet.ibm.com>

Powered by blists - more mailing lists