linux-kernel - Re: [PATCH v2 1/3] ARM: davinci: hawk: use gpio descriptor for mmc pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2016 13:44:38 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Axel Haslam <ahaslam@...libre.com>, <khilman@...libre.com>,
        <ptitiano@...libre.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] ARM: davinci: hawk: use gpio descriptor for mmc
 pins

On Thursday 24 November 2016 08:34 PM, Axel Haslam wrote:
> Currently the mmc driver is polling the gpio to know if the
> card was removed.
> 
> By using a gpio descriptor instead of the platform callbacks,
> the driver will be able to register the gpio using the mmc core
> API's designed for this purpose.

s/API's/APIs

> 
> This has the advantage that an irq will be registered, and
> polling is no longer needed. Also, a dependency on platform
> callbacks is removed for this board.
> 
> Signed-off-by: Axel Haslam <ahaslam@...libre.com>
> ---
>  arch/arm/mach-davinci/board-omapl138-hawk.c | 42 ++++++++---------------------
>  1 file changed, 11 insertions(+), 31 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
> index a4e8726..a2966d3 100644
> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
> @@ -15,6 +15,7 @@
>  #include <linux/gpio.h>
>  #include <linux/platform_data/gpio-davinci.h>
>  #include <linux/regulator/machine.h>
> +#include <linux/gpio/machine.h>

Moved this include to below linux/gpio.h

Applied to v4.10/soc

Thanks,
Sekhar