linux-kernel - Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161128082819.GA31105@lst.de>
Date:   Mon, 28 Nov 2016 09:28:19 +0100
From:   Christoph Hellwig <hch@....de>
To:     Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Cc:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Julia Lawall <julia.lawall@...6.fr>, kbuild-all@...org,
        Felipe Balbi <balbi@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        target-devel <target-devel@...r.kernel.org>,
        Joel Becker <jlbec@...lplan.org>,
        linux-nvme@...ts.infradead.org, Christoph Hellwig <hch@....de>,
        "Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Subject: Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

On Wed, Nov 23, 2016 at 09:35:36AM +0100, Andrzej Pietrasiewicz wrote:
> The ->drop_item() is indeed a void function, the ->drop_link() is
> actually not. This, together with the fact that the value of ->drop_link()
> is silently ignored suggests, that it is the ->drop_link() return
> type that should be corrected and changed to void.

Please send a patch to change it.