lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 27 Nov 2016 18:10:46 -0800
From:   John Muir <>
To:     Guenter Roeck <>
Cc:     Jean Delvare <>, Jonathan Corbet <>,
        Mark Rutland <>,
        Rob Herring <>,
        Linux List <>,,
Subject: Re: [PATCH 3/3] hwmon: tmp108: Update driver to use hwmon_chip_info.

> On 2016.11.27, at 15:00 , Guenter Roeck <> wrote:
> On Sat, Nov 26, 2016 at 09:15:37PM -0800, John Muir wrote:
>> Move the tmp108 driver from hwmon attribute groups to
>> hwmon_chip_info.
>> Signed-off-by: John Muir <>
>> ---
> Hi John,
> please have a look at the following patch.
> Something else: Symbolic permissions are out of favor nowadays.
> You might instead just use 0644 / 0444. Not that I really care,
> but it prevents the inevitable follow-up patches.

Hi Guenter,

Thank you for this patch. I will attempt to implement the same changes using the older interfaces in my 4.4 implementation. I will incorporate your changes and other comments as soon as I can (early this week) and re-send my patch series.



Powered by blists - more mailing lists