linux-kernel - Re: module: extend 'rodata=off' boot cmdline parameter to module mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8760n88ocq.fsf@rustcorp.com.au>
Date:   Mon, 28 Nov 2016 10:30:53 +1030
From:   Rusty Russell <rusty@...tcorp.com.au>
To:     Jessica Yu <jeyu@...hat.com>,
        AKASHI Takahiro <takahiro.akashi@...aro.org>
Cc:     mark.rutland@....com, keescook@...omium.org,
        kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org
Subject: Re: module: extend 'rodata=off' boot cmdline parameter to module mappings

Jessica Yu <jeyu@...hat.com> writes:

> +++ AKASHI Takahiro [14/11/16 15:15 +0900]:
>>The current "rodata=off" parameter disables read-only kernel mappings
>>under CONFIG_DEBUG_RODATA:
>>    commit d2aa1acad22f ("mm/init: Add 'rodata=off' boot cmdline parameter
>>    to disable read-only kernel mappings")
>>
>>This patch is a logical extension to module mappings ie. read-only mappings
>>at module loading can be disabled even if CONFIG_DEBUG_SET_MODULE_RONX
>>(mainly for debug use). Please note, however, that it only affects RO/RW
>>permissions, keeping NX set.
>>
>>This is the first step to make CONFIG_DEBUG_SET_MODULE_RONX mandatory
>>(always-on) in the future as CONFIG_DEBUG_RODATA on x86 and arm64.
>>
>>Suggested-by: and Acked-by: Mark Rutland <mark.rutland@....com>
>>Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>
>>Reviewed-by: Kees Cook <keescook@...omium.org>
>>Cc: Rusty Russell <rusty@...tcorp.com.au>
>
> Hi Rusty, could I get an (n)ack for this patch? :-)

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Cheers,
Rusty.