linux-kernel - Re: [PATCH v2] HID: i2c-hid: force the IRQ level trigger only when not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1611281442550.29400@cbobk.fhfr.pm>
Date:   Mon, 28 Nov 2016 14:43:08 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: i2c-hid: force the IRQ level trigger only when
 not set

On Mon, 21 Nov 2016, Benjamin Tissoires wrote:

> Instead of forcing the level trigger of the IRQ, we can count
> on ACPI or OF to set it up for us.
> 
> The first release of the HID over I2C specification mentioned
> that the level trigger needed to be active low. In the latest
> version of the specification, there is no such explicit mention,
> so it's better to not assume one.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> 
> ---
> 
> changes in v2:
> - reword a little the commit message (and mention that the new spec
>   doesn't requires active low anymore)
> - add missing irq.h include as per kbuild bot raised
> 
> So after the kbuild bot warning and a search in my email folder, I realised
> that the commit message should be amended too. So here is a v2 :)

Applied to for-4.10/i2c-hid. Thanks,

-- 
Jiri Kosina
SUSE Labs