linux-kernel - Re: Kernel Panics on Xen ARM64 for Domain0 and Guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161128152915.GA7806@htj.duckdns.org>
Date:   Mon, 28 Nov 2016 10:29:15 -0500
From:   "tj@...nel.org" <tj@...nel.org>
To:     Julien Grall <julien.grall@....com>
Cc:     Wei Chen <Wei.Chen@....com>, "zijun_hu@....com" <zijun_hu@....com>,
        "cl@...ux.com" <cl@...ux.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
        Kaly Xin <Kaly.Xin@....com>,
        Steve Capper <Steve.Capper@....com>,
        Stefano Stabellini <sstabellini@...nel.org>
Subject: Re: Kernel Panics on Xen ARM64 for Domain0 and Guest

Hello,

On Mon, Nov 28, 2016 at 11:59:15AM +0000, Julien Grall wrote:
> > commit 3ca45a46f8af8c4a92dd8a08eac57787242d5021
> > percpu: ensure the requested alignment is power of two
> 
> It would have been useful to specify the tree used. In this case,
> this commit comes from linux-next.

I'm surprised this actually triggered.

> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index f193414..4986dc0 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -372,8 +372,7 @@ static int __init xen_guest_init(void)
>          * for secondary CPUs as they are brought up.
>          * For uniformity we use VCPUOP_register_vcpu_info even on cpu0.
>          */
> -       xen_vcpu_info = __alloc_percpu(sizeof(struct vcpu_info),
> -                                              sizeof(struct vcpu_info));
> +       xen_vcpu_info = alloc_percpu(struct vcpu_info);
>         if (xen_vcpu_info == NULL)
>                 return -ENOMEM;

Yes, this looks correct.  Can you please cc stable too?  percpu
allocator never supported alignments which aren't power of two and has
always behaved incorrectly with alignments which aren't power of two.

Thanks.

-- 
tejun