linux-kernel - Re: [PATCH 0/2] more quirks for hid-sensor-hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1480351997.6544.236.camel@linux.intel.com>
Date:   Mon, 28 Nov 2016 08:53:17 -0800
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>
Cc:     linux-input@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] more quirks for hid-sensor-hub

Hi Benjamin,

On Fri, 2016-11-25 at 11:03 +0100, Benjamin Tissoires wrote:
> Hi Jiri,
> 
> here are 2 more quirks for the sensor-hub.
> 
> Srinivas, I am wondering if we can not detect those automatically.
> Looking at the report_fixup, it looks like the buggy report
> descriptors have
> a logical max of 5 (which would correspond to an enum of 0 to 5). But
> there
> are 6 fields in the enum, so that means the report descriptor is just
> wrong.
> 
> Given that Microsoft's driver requires a min of 1, wouldn't it be too
> much
> assumption to say that we need to fix the report descriptor anyway
> when we
> see a range of 0..5 instead of 1..6?

The problem is that they should have also changed logical minimum,
which vendors didn't do as Windows driver will always assume
enumeration base as 1.

As far as I can tell there was only Windows platform where base was 0,
but I am sure that Windows update and BIOS update would have fixed that
by now after 3 years.

I am in opinion to change this to match this with Windows driver, so
that we don't need this quirks. This is a small change in IIO sensor
hub driver.

If nobody has objection, I can submit a trivial change for this.

Thanks,
Srinivas


> 
> Cheers,
> Benjamin
> 
> Benjamin Tissoires (2):
>   HID: sensor-hub add quirk for Microsoft Surface 3
>   HID: sensor-hub: add quirk for Microchip MM7150
> 
>  drivers/hid/hid-sensor-hub.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>