linux-kernel - Re: [PATCH 2/6] perf tool: Move parse_nsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8239a06e-df1e-84cc-ec3c-3fdd22c3fe0a@gmail.com>
Date:   Mon, 28 Nov 2016 10:31:14 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>, David Ahern <dsa@...ulusnetworks.com>
Cc:     acme@...nel.org, mingo@...nel.org, peterz@...radead.org,
        namhyung@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] perf tool: Move parse_nsec_time to time-utils.c

On 11/28/16 6:58 AM, Jiri Olsa wrote:
>> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
>> index 79662d67891e..1d639e38aa82 100644
>> --- a/tools/perf/util/util.h
>> +++ b/tools/perf/util/util.h
>> @@ -179,8 +179,6 @@ static inline void *zalloc(size_t size)
>>  #undef tolower
>>  #undef toupper
>>  
>> -int parse_nsec_time(const char *str, u64 *ptime);
> 
> strange, can't see any current user of this function other than in your patch

Added a few years back. I switched my code to it at that point. odd that there are no other users, but it has worked for me since it was added.

> 
> could you please also add some automated tests for this function?

Why? It is basically a fancy wrapper around strtoul for sec.usec strings.