linux-kernel - Re: module: extend 'rodata=off' boot cmdline parameter to module mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161128195055.GC24161@packer-debian-8-amd64.digitalocean.com>
Date:   Mon, 28 Nov 2016 14:50:55 -0500
From:   Jessica Yu <jeyu@...hat.com>
To:     AKASHI Takahiro <takahiro.akashi@...aro.org>,
        Andreas Ziegler <andreas.ziegler@....de>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Kees Cook <keescook@...omium.org>,
        kernel-hardening@...ts.openwall.com,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: module: extend 'rodata=off' boot cmdline parameter to module
 mappings

+++ AKASHI Takahiro [28/11/16 18:18 +0900]:
>On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
>> Hi Akashi,
>>
>> your patch "module: extend 'rodata=off' boot cmdline parameter to module
>> mappings" showed up in linux-next today, and I noticed a small error in it.
>>
>> The first modified #ifdef is fine, the second one, however, has a spelling
>> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
>> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).
>
>Thank you for pointing this out.
>(I didn't notice it because DEBUG_RODATA is always on on arm64.)
>
>Rusty, Jessica, should I submit v4 to correct it?

Andreas, Akashi -

The typo has been fixed with Arnd's patch:

   http://lkml.kernel.org/r/20161128145931.3350661-1-arnd@arndb.de

Thanks for finding the issue!

Jessica