linux-kernel - Re: [PATCH 1/1] libnvdimm, namespace: fix the type of name variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161128212626.GB16225@linux.intel.com>
Date:   Mon, 28 Nov 2016 14:26:26 -0700
From:   Ross Zwisler <ross.zwisler@...ux.intel.com>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Dan Williams <dan.j.williams@...el.com>, linux-nvdimm@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] libnvdimm, namespace: fix the type of name variable

On Sat, Nov 26, 2016 at 08:18:04PM +0100, Nicolas Iooss wrote:
> In create_namespace_blk(), the local variable "name" is defined as an
> array of NSLABEL_NAME_LEN pointers:
> 
>     char *name[NSLABEL_NAME_LEN];
> 
> This variable is then used in calls to memcpy() and kmemdup() as if it
> were char[NSLABEL_NAME_LEN]. Remove the star in the variable definition
> to makes it look right.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>

Yep, nice catch.

Reviewed-by: Ross Zwisler <ross.zwisler@...ux.intel.com>