lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Nov 2016 09:44:52 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Arnd Bergmann <arnd@...db.de> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, Len Brown <lenb@...nel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Philippe Longepe <philippe.longepe@...ux.intel.com>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] cpufreq: intel_pstate: fix intel_pstate_exit_perf_limits prototype On 25-11-16, 17:50, Arnd Bergmann wrote: > The addition of the generic governor support marked the > intel_pstate_exit_perf_limits as inline, which fixed a warning, > but it introduced another warning: > > drivers/cpufreq/intel_pstate.c: In function ‘intel_pstate_exit_perf_limits’: > drivers/cpufreq/intel_pstate.c:483:1: error: no return statement in function returning non-void [-Werror=return-type] > > This changes it back to a 'void' return type, and changes the > corresponding intel_pstate_init_acpi_perf_limits() function to > be inline as well for consistency. > > Fixes: 001c76f05b01 ("cpufreq: intel_pstate: Generic governors support") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/cpufreq/intel_pstate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 7159dbde0160..8921686b8cd2 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -474,11 +474,11 @@ static void intel_pstate_exit_perf_limits(struct cpufreq_policy *policy) > } > > #else > -static void intel_pstate_init_acpi_perf_limits(struct cpufreq_policy *policy) > +static inline void intel_pstate_init_acpi_perf_limits(struct cpufreq_policy *policy) > { > } > > -static inline int intel_pstate_exit_perf_limits(struct cpufreq_policy *policy) > +static inline void intel_pstate_exit_perf_limits(struct cpufreq_policy *policy) > { > } > #endif Acked-by: Viresh Kumar <viresh.kumar@...aro.org> -- viresh
Powered by blists - more mailing lists