linux-kernel - RE: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2016 23:45:50 +0000
From:   "Chen, Yu C" <yu.c.chen@...el.com>
To:     John Stultz <john.stultz@...aro.org>
CC:     Ingo Molnar <mingo@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Xunlei Pang <xlpang@...hat.com>,
        Ingo Molnar <mingo@...hat.com>, Len Brown <lenb@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Pavel Machek <pavel@....cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        Prarit Bhargava <prarit@...hat.com>,
        Richard Cochran <richardcochran@...il.com>
Subject: RE: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if
 pm_trace is enabled


> -----Original Message-----
> From: John Stultz [mailto:john.stultz@...aro.org]
> Sent: Tuesday, November 29, 2016 2:39 AM
> To: Chen, Yu C
> Cc: Ingo Molnar; lkml; Rafael J. Wysocki; Xunlei Pang; Ingo Molnar; Len Brown;
> H. Peter Anvin; Pavel Machek; Thomas Gleixner; Prarit Bhargava; Richard
> Cochran
> Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace
> is enabled
> 
> On Thu, Nov 24, 2016 at 1:54 AM, Chen, Yu C <yu.c.chen@...el.com> wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Ingo Molnar [mailto:mingo.kernel.org@...il.com] On Behalf Of
> >> Ingo Molnar
> >> Sent: Monday, November 21, 2016 4:18 PM
> >> To: John Stultz
> >> Cc: lkml; Chen, Yu C; Rafael J. Wysocki; Xunlei Pang; Ingo Molnar; Len Brown;
> H.
> >> Peter Anvin; Pavel Machek; Thomas Gleixner; Prarit Bhargava; Richard
> >> Cochran
> >> Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if
> >> pm_trace is enabled
> >>
> >>
> >> * John Stultz <john.stultz@...aro.org> wrote:
> >>
> >> > +static int pm_trace_notify(struct notifier_block *nb,
> >> > +                           unsigned long mode, void *_unused) {
> >> > +   switch (mode) {
> >> > +   case PM_POST_HIBERNATION:
> >> > +   case PM_POST_SUSPEND:
> >> > +           if (pm_trace_rtc_abused) {
> >> > +                   pm_trace_rtc_abused = false;
> >> > +                   pr_warn("Possible incorrect RTC due to pm_trace,"
> >> > +                           "please use ntp-date or rdate to
> >> > +reset.\n");
> >>
> >> Please don't break user-visible strings just to pacify checkpatch!
> >>
> >> The bogus linebreak above hides a type in the user string:
> >>
> >>   Possible incorrect RTC due to pm_trace,please use ntp-date or rdate to
> reset.
> >>
> >> (There's a missing space after the comma.)
> >>
> >> Best practice is to preserve the continuous nature of the user string in the
> code.
> >>
> >> In addition to that, please quote suggested command names, i.e. something
> like:
> >>
> >>   Possible incorrect RTC due to pm_trace, please use 'ntp-date' or
> >> 'rdate' to reset it.
> > OK, will do.
> 
> Just a heads up. I've already made these changes in my tree.
> 
> thanks
> -john
OK, thanks very much!  john. 

Yu