linux-kernel - Re: [tip:x86/urgent] x86/apic/uv: Silence a shift wrapping warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161129210656.GC67776@stormcage.americas.sgi.com>
Date:   Tue, 29 Nov 2016 15:06:56 -0600
From:   Alex Thorlton <athorlton@....com>
To:     dan.carpenter@...cle.com, mingo@...nel.org, nzimmer@....com,
        linux-kernel@...r.kernel.org, travis@....com, tglx@...utronix.de,
        hpa@...or.com, bigeasy@...utronix.de, athorlton@....com,
        torvalds@...ux-foundation.org, peterz@...radead.org,
        sivanich@....com
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86/apic/uv: Silence a shift wrapping warning

On Wed, Nov 23, 2016 at 10:25:48PM -0800, tip-bot for Dan Carpenter wrote:
> Commit-ID:  c4597fd756836a5fb7900f2091797ab564390ad0
> Gitweb:     http://git.kernel.org/tip/c4597fd756836a5fb7900f2091797ab564390ad0
> Author:     Dan Carpenter <dan.carpenter@...cle.com>
> AuthorDate: Thu, 24 Nov 2016 01:19:08 +0300
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Thu, 24 Nov 2016 06:01:05 +0100
> 
> x86/apic/uv: Silence a shift wrapping warning
> 
> 'm_io' is stored in 6 bits so it's a number in the 0-63 range.  Static
> analysis tools complain that 1 << 63 will wrap so I have changed it to
> 1ULL << m_io.
> 
> This code is over three years old so presumably the bug doesn't happen
> very frequently in real life or someone would have complained by now.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Alex Thorlton <athorlton@....com>

Acked-by: Alex Thorlton <athorlton@....com>

- Alex