linux-kernel - Re: [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161129211054.GD6095@codeaurora.org>
Date:   Tue, 29 Nov 2016 13:10:54 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Xiaolong Zhang <xiaolong.zhang@...eadtrum.com>
Cc:     mturquette@...libre.com, orson.zhai@...eadtrum.com,
        ben.li@...eadtrum.com, baolin.wang@...eadtrum.com,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: Register clkdev after setup of fixed-rate and
 fixed-factor clocks

On 11/24, Xiaolong Zhang wrote:
> On 三, 11月 23, 2016 at 04:38:33下午 -0800, Stephen Boyd wrote:
> 
> > We're really off track now though. Can you please point to some
> > code that needs this change? If we're using DT then we should be
> > able to use the of_clk_*() path to find the clk.
> >
> 
> Actually, the requirement is raised by our GPU driver. In the
> early stage of the GPU DT driver, the GPU driver use the
> clk_get(NULL, con_id) to get the clock instance for compatible
> with non-DT GPU driver. The new driver have used the of_clk_get()
> instead of the clk_get. And we reserved the modification in clock.
> 

Ok the non-DT version of the GPU driver should be modified to
call clk_get() and pass in the device. The con_id argument there
should be something specific to the GPU device, and not a global
name of a clock on the system. When the clkdev lookup is
populated on the non-DT board make sure to set the dev_id string
to match the device name of the GPU device.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project