linux-kernel - Re: [PATCH] tty: nozomi: avoid sprintf buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5750086.0s0vVYgDjM@wuerfel>
Date:   Tue, 29 Nov 2016 10:10:34 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Peter Hurley <peter@...leysoftware.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: nozomi: avoid sprintf buffer overflow

On Tuesday, November 29, 2016 8:14:32 AM CET Jiri Slaby wrote:
> 
> Could you also kill the now unused _err_flag_ parameter (including the
> only user of NFO)?

Right. I was trying to avoid taking the cleanup too far, lacking
a way to properly test it, but that would have been an obvious change.
 
> (Or inline pr_debug directly into the only user and kill NFO completely?)

I'll send both variants and let you pick one or the other.

	Arnd