linux-kernel - Re: [PATCH v2] drm: tilcdc: fix parsing of some DT properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e54f3479-b849-4195-07c7-72d97c40883d@ti.com>
Date:   Tue, 29 Nov 2016 11:24:20 +0200
From:   Jyri Sarha <jsarha@...com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        David Airlie <airlied@...ux.ie>,
        Kevin Hilman <khilman@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Sekhar Nori <nsekhar@...com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        linux-drm <dri-devel@...ts.freedesktop.org>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        arm-soc <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] drm: tilcdc: fix parsing of some DT properties

On 11/28/16 13:37, Bartosz Golaszewski wrote:
> The DT binding for tildc is not consistent with the driver code: there
> are two options - 'max-width' and 'max-pixelclock' specified in the
> documentation which are parsed as 'ti,max-width' and
> 'ti'max-pixelclock' respectively.
> 
> Make the driver code consistent with the binding.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Reviewed-by: Jyri Sarha <jsarha@...com>

I'll pick this up for a pull request that I'll send shortly.

> ---
> v1 -> v2:
> - fix max-pixelclock too
> 
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 5efb369..bd0a3bd 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -296,12 +296,12 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev)
>  
>  	DBG("Maximum Bandwidth Value %d", priv->max_bandwidth);
>  
> -	if (of_property_read_u32(node, "ti,max-width", &priv->max_width))
> +	if (of_property_read_u32(node, "max-width", &priv->max_width))
>  		priv->max_width = TILCDC_DEFAULT_MAX_WIDTH;
>  
>  	DBG("Maximum Horizontal Pixel Width Value %dpixels", priv->max_width);
>  
> -	if (of_property_read_u32(node, "ti,max-pixelclock",
> +	if (of_property_read_u32(node, "max-pixelclock",
>  					&priv->max_pixelclock))
>  		priv->max_pixelclock = TILCDC_DEFAULT_MAX_PIXELCLOCK;
>  
>