linux-kernel - Re: [PATCH v3 00/33] Radix tree patches for 4.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161129112446.GA8837@node.shutemov.name>
Date:   Tue, 29 Nov 2016 14:24:46 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Matthew Wilcox <mawilcox@...uxonhyperv.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Konstantin Khlebnikov <koct9i@...il.com>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Matthew Wilcox <mawilcox@...rosoft.com>, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH v3 00/33] Radix tree patches for 4.10

On Mon, Nov 28, 2016 at 01:50:04PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox <mawilcox@...rosoft.com>
> 
> Hi Andrew,
> 
> Please include these patches in the -mm tree for 4.10.  Mostly these
> are improvements; the only bug fixes in here relate to multiorder
> entries (which are unused in the 4.9 tree).  The IDR rewrite has the
> highest potential for causing mayhem as the test suite is quite spartan.
> We have an Outreachy intern scheduled to work on the test suite for the
> 2016 winter season, so hopefully it will improve soon.
> 
> I did not include Konstantin's suggested change to the API for
> radix_tree_iter_resume().  Many of the callers do not currently care
> about the size of the entry they are consuming, and determining that
> information is not always trivial.  Since this is not a performance
> critical API (it's called when we've paused iterating through a tree
> in order to schedule for a higher priority task), I think it's more
> important to have a simpler interface.
> 
> I'd like to thank Kiryl for all the testing he's been doing.  He's found
> at least two bugs which weren't related to the API extensions that he
> really wanted from this patch set.

Tested-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

I would like to get in as my ext4 patchset depends on this.

-- 
 Kirill A. Shutemov