linux-kernel - Re: [PATCH v2] platform/chrome: Use proper protocol transfer function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8610e219-8b9a-3010-70b7-b43aaef7cf2b@osg.samsung.com>
Date:   Tue, 29 Nov 2016 09:20:10 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Brian Norris <briannorris@...omium.org>,
        Olof Johansson <olof@...om.net>,
        Benson Leung <bleung@...omium.org>
Cc:     Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        Doug Anderson <dianders@...omium.org>,
        Brian Norris <computersforpeace@...il.com>,
        Shawn Nematbakhsh <shawnn@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Enric Balletbo <enric.balletbo@...labora.co.uk>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>
Subject: Re: [PATCH v2] platform/chrome: Use proper protocol transfer function

Hello Brian,

On 11/28/2016 07:19 PM, Brian Norris wrote:
> From: Shawn Nematbakhsh <shawnn@...omium.org>
> 
> pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had
> one instance of these functions correct, but not the second, fall-back
> case. We use the fall-back only when the first command returns an
> IN_PROGRESS status, which is only used on some EC firmwares where we
> don't want to constantly poll the bus, but instead back off and
> sleep/retry for a little while.
> 

That's correct, sorry for missing this when pushing the patch to mainline.

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America