linux-kernel - Re: [PATCH] Scripts: kconfig: nconf: fix _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161129130508.GA16422@sepie.suse.cz>
Date:   Tue, 29 Nov 2016 14:05:08 +0100
From:   Michal Marek <mmarek@...e.com>
To:     Paul Bolle <pebolle@...cali.nl>
Cc:     Cheah Kok Cheong <thrust73@...il.com>,
        Michal Marek <mmarek@...e.cz>, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined
 warning

On Mon, Nov 28, 2016 at 09:29:21PM +0100, Paul Bolle wrote:
> [Dropped Yann.]
> 
> On Tue, 2016-11-29 at 02:46 +0800, Cheah Kok Cheong wrote:
> > On Mon, Nov 28, 2016 at 11:39:01AM +0100, Michal Marek wrote:
> > > The Makefile does not specify -D_GNU_SOURCE. Are you adding it manually?
> 
> On Fedora 24 I'm able to trigger this too:
>     $ [...]
>     make -f ./scripts/Makefile.build obj=scripts/kconfig nconfig
>       gcc -Wp,-MD,scripts/kconfig/.nconf.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -std=gnu89   -D_GNU_SOURCE -DCURSES_LOC="<ncurses.h>" -DNCURSES_WIDECHAR=1 -DLOCALE   -c -o scripts/kconfig/nconf.o scripts/kconfig/nconf.c
>     scripts/kconfig/nconf.c:8:0: warning: "_GNU_SOURCE" redefined
>      #define _GNU_SOURCE
>      
>     <command-line>:0:0: note: this is the location of the previous definition
> 
> It's probably added by pkg-config:
>     $ pkg-config --cflags ncursesw
>     -D_GNU_SOURCE

I see. That's not nice of the pkconfig file to set such macro, but oh
well. I applied the patch to kbuild.git#kconfig now, thanks Cheah.

Michal