linux-kernel - Re: [PATCH] USB: OHCI: use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20161129140343.GB3605@kroah.com>
Date:   Tue, 29 Nov 2016 15:03:43 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     csmanjuvijay@...il.com
Cc:     Arnd Bergmann <arnd@...db.de>, Vladimir Zapolskiy <vz@...ia.com>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        Alan Stern <stern@...land.harvard.edu>,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: OHCI: use module_platform_driver macro

On Tue, Nov 22, 2016 at 01:49:22PM +0000, csmanjuvijay@...il.com wrote:
> From: Manjunath Goudar <csmanjuvijay@...il.com>
> 
> Use the module_platform_driver macro to do module init/exit.
> This eliminates a lot of boilerplate.This also removes
> checkpatch.pl errors.
> 
> Signed-off-by: Manjunath Goudar <csmanjuvijay@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Vladimir Zapolskiy <vz@...ia.com>
> Cc: Sylvain Lemieux <slemieux.tyco@...il.com>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-usb@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/usb/host/ohci-nxp.c | 38 ++++++++++++++------------------------
>  1 file changed, 14 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index b7d4756..9908647 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -56,8 +56,6 @@ static struct hc_driver __read_mostly ohci_nxp_hc_driver;
>  
>  static struct i2c_client *isp1301_i2c_client;
>  
> -extern int usb_disabled(void);
> -
>  static struct clk *usb_host_clk;
>  
>  static void isp1301_configure_lpc32xx(void)
> @@ -127,6 +125,7 @@ static inline void isp1301_vbus_off(void)
>  static void ohci_nxp_start_hc(void)
>  {
>  	unsigned long tmp = __raw_readl(USB_OTG_STAT_CONTROL) | HOST_EN;
> +
>  	__raw_writel(tmp, USB_OTG_STAT_CONTROL);
>  	isp1301_vbus_on();
>  }
> @@ -134,6 +133,7 @@ static void ohci_nxp_start_hc(void)
>  static void ohci_nxp_stop_hc(void)
>  {
>  	unsigned long tmp;
> +
>  	isp1301_vbus_off();
>  	tmp = __raw_readl(USB_OTG_STAT_CONTROL) & ~HOST_EN;
>  	__raw_writel(tmp, USB_OTG_STAT_CONTROL);

Why make these last two changes?  They are just coding style "fixups"
that have nothing to do with this patch :(

When you say "also" in a patch description, that's a huge flag that you
should be splitting the patch up into multiple patches.  Please do so
here.

thanks,

greg k-h